Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate system tutorial #2009

Merged
merged 12 commits into from
Mar 1, 2023

Conversation

rpartsey
Copy link
Collaborator

Motivation and Context

An updated version of #1498.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 15, 2023
@rpartsey
Copy link
Collaborator Author

rpartsey commented Feb 15, 2023

@dhruvbatra It turned out that even though the PR #1498 was open on Sep 22, 2021, the code was written so well that it works like a charm even after merging current main. I've also updated code to be more similar to other sim tutorials.

The updated cached colab version of the tutorial can be found here. Let me know if you want something specific to be added/addressed.

Should I also add a corresponding doc page for the aihabitat website?

@dhruvbatra
Copy link
Contributor

Yeah, @eundersander does has a habit of writing code like that 😄. Cached colab tutorial looks great! No comments.

Yes, let's add a corresponding docs page and list it in the docs. Thanks @rpartsey!

@rpartsey
Copy link
Collaborator Author

Looks like one of flaky tests is failing 3/3 times. The functionality that may impact the test wasn't touched and it is not reproducible on the other PRs.

@rpartsey
Copy link
Collaborator Author

Looks like one of flaky tests is failing 3/3 times. The functionality that may impact the test wasn't touched and it is not reproducible on the other PRs.

Fixed on habitat-lab side in scope of facebookresearch/habitat-lab#1134.

@rpartsey rpartsey requested review from dhruvbatra and aclegg3 and removed request for aclegg3 and dhruvbatra February 28, 2023 14:42
@rpartsey rpartsey merged commit 784c967 into facebookresearch:main Mar 1, 2023
@rpartsey rpartsey deleted the coordinate_system_tutorial branch March 1, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants