Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replay renderer bindings to get CUDA device pointers. #2011

Merged
merged 6 commits into from
Feb 27, 2023
Merged

Add replay renderer bindings to get CUDA device pointers. #2011

merged 6 commits into from
Feb 27, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Feb 16, 2023 •
edited
Loading

Motivation and Context

This adds replay renderer bindings to get CUDA device pointers from Python.

How Has This Been Tested

Device pointers are tested in BatchReplayRendererTest.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 16, 2023
@0mdc 0mdc marked this pull request as ready for review February 16, 2023 15:43
mosra
mosra reviewed Feb 16, 2023
View reviewed changes
src/esp/bindings/SimBindings.cpp Show resolved Hide resolved
src/esp/bindings/SimBindings.cpp Outdated Show resolved Hide resolved
src/esp/sim/BatchReplayRenderer.cpp Show resolved Hide resolved
eundersander
eundersander approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit 7f02653 into facebookresearch:main Feb 27, 2023
@mosra mosra mentioned this pull request Mar 6, 2023
Closed
11 tasks
@0mdc 0mdc deleted the batch-renderer-api branch June 14, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosra mosra mosra left review comments

@eundersander eundersander eundersander approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0mdc @mosra @Skylion007 @eundersander @facebook-github-bot