Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiGoalShortestPath improvements #2014

Merged
merged 5 commits into from
Feb 28, 2023
Merged

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Feb 22, 2023

Motivation and Context

Currently, if any of the requested_end points don't snap to the navmesh, MultiGoalShortestPath will early abort and return inf distance.
Expected behavior: if any of the points in requested_ends are valid, the shortest path should be computed accurately.

Additional feature: adds closest_end_point_index to MultiGoalShortestPath struct API. Makes it easier to know which point form the input set was actually selected as closets. Corresponds to the end of the path.

How Has This Been Tested

TODO:
May need to update tests to check these edge cases:

  • all points off navmesh
  • some points off navmesh
  • all points on other island
  • all point son other island or off navmesh

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 22, 2023
@aclegg3 aclegg3 changed the title Remove early return from MultiGoalShortestPath MultiGoalShortestPath improvements Feb 22, 2023
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aclegg3 aclegg3 merged commit de8ed5f into main Feb 28, 2023
@aclegg3 aclegg3 deleted the multigoalshortestpath-no-early-return branch February 28, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants