-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiGoalShortestPath improvements #2014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Feb 22, 2023
aclegg3
changed the title
Remove early return from MultiGoalShortestPath
MultiGoalShortestPath improvements
Feb 22, 2023
jturner65
reviewed
Feb 22, 2023
jturner65
reviewed
Feb 22, 2023
Skylion007
reviewed
Feb 23, 2023
Skylion007
reviewed
Feb 23, 2023
7 tasks
jturner65
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jturner65
approved these changes
Feb 28, 2023
jturner65
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, if any of the requested_end points don't snap to the navmesh,
MultiGoalShortestPath
will early abort and returninf
distance.Expected behavior: if any of the points in
requested_ends
are valid, the shortest path should be computed accurately.Additional feature: adds
closest_end_point_index
toMultiGoalShortestPath
struct API. Makes it easier to know which point form the input set was actually selected as closets. Corresponds to the end of thepath
.How Has This Been Tested
TODO:
May need to update tests to check these edge cases:
Types of changes
Checklist