Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python binding to render color sensors into CPU images. #2029

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 13, 2023

Motivation and Context

This adds a missing replay renderer python binding to transfer sensor output into CPU images.
Note that this function only works for one color sensor. This will be revisited as we integrate multiple sensors into the batch renderer.

How Has This Been Tested

Tested manually in Python from Habitat-Lab.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested review from mosra and eundersander March 13, 2023 14:11
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 13, 2023
@0mdc 0mdc force-pushed the batch-renderer-gpu-to-cpu-api branch from 1089fad to f0f8f60 Compare March 13, 2023 14:16
@0mdc 0mdc force-pushed the batch-renderer-gpu-to-cpu-api branch from f0f8f60 to 90eec2b Compare March 13, 2023 14:17
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit 876f60a into main Mar 15, 2023
@0mdc 0mdc deleted the batch-renderer-gpu-to-cpu-api branch May 29, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants