Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python to 3.9. #2030

Merged
merged 11 commits into from
Mar 24, 2023
Merged

Upgrade python to 3.9. #2030

merged 11 commits into from
Mar 24, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 14, 2023

Motivation and Context

As Python 3.7 is nearing end-of-life, we are upgrading Habitat's minimum Python version to 3.9. Some of our dependencies are deprecating Python 3.7, like PyTorch and NumPy. We will also benefit from performance improvements and overall modernization.

Habitat-lab changeset:

How Has This Been Tested

Tested locally and on CI.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 14, 2023
@0mdc 0mdc force-pushed the python-3.9-upgrade branch 4 times, most recently from 592255e to ccbf98a Compare March 15, 2023 16:07
conda-build/README.md Outdated Show resolved Hide resolved
@0mdc 0mdc force-pushed the python-3.9-upgrade branch 5 times, most recently from 064a747 to 1acd5c1 Compare March 21, 2023 01:59
@0mdc 0mdc force-pushed the python-3.9-upgrade branch 4 times, most recently from 042eac0 to 8c41b4a Compare March 22, 2023 00:30
@0mdc 0mdc requested a review from rpartsey March 23, 2023 21:37
@0mdc 0mdc marked this pull request as ready for review March 23, 2023 21:38
git submodule update --init --recursive --jobs 8
pip install .
pip uninstall -y habitat-sim
rm -rf build
Copy link
Contributor Author

@0mdc 0mdc Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This somehow makes conda build work on the osx image. We're not exactly sure why.

It adds ~13 minutes to the build stage, but we can live with it for now.
Fortunately, this hack won't be necessary when we move from setup.py install to pip install ..

Thanks @rpartsey for reproducing the issue and finding the workaround.

Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@0mdc 0mdc merged commit e7f5705 into main Mar 24, 2023
@0mdc 0mdc deleted the python-3.9-upgrade branch May 29, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants