-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade python to 3.9. #2030
Upgrade python to 3.9. #2030
Conversation
592255e
to
ccbf98a
Compare
77972dd
to
5ce64b6
Compare
This reverts commit 27a1cee.
064a747
to
1acd5c1
Compare
042eac0
to
8c41b4a
Compare
8101883
to
e2f68c1
Compare
git submodule update --init --recursive --jobs 8 | ||
pip install . | ||
pip uninstall -y habitat-sim | ||
rm -rf build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This somehow makes conda build
work on the osx image. We're not exactly sure why.
It adds ~13 minutes to the build stage, but we can live with it for now.
Fortunately, this hack won't be necessary when we move from setup.py install
to pip install .
.
Thanks @rpartsey for reproducing the issue and finding the workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Motivation and Context
As Python 3.7 is nearing end-of-life, we are upgrading Habitat's minimum Python version to 3.9. Some of our dependencies are deprecating Python 3.7, like PyTorch and NumPy. We will also benefit from performance improvements and overall modernization.
Habitat-lab changeset:
How Has This Been Tested
Tested locally and on CI.
Types of changes
Checklist