Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional magnum importer plugins in python build dependencies #2105

Merged
merged 4 commits into from
May 16, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 15, 2023

Motivation and Context

Python importer used in Habitat-lab requires linked Magnum plugins from Habitat=sim.

How Has This Been Tested

NA

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 15, 2023
src/cmake/dependencies.cmake Outdated Show resolved Hide resolved
@@ -357,7 +357,6 @@ if(NOT USE_SYSTEM_MAGNUM)
MagnumPlugins::AssimpImporter
MagnumPlugins::BasisImporter
MagnumPlugins::GltfImporter
MagnumPlugins::StanfordImporter
Copy link
Collaborator

@mosra mosra May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove StanfordImporter as it doesn't support ASCII ply.

Ah, that's one of my TODOs. I'm not interested in implementing parsing of ASCII PLY files myself, but it could delegate to Assimp for those.

Where do these come from, btw? Is there some Habitat code that writes them? Might be a candidate for refactor / replacement with builtin Magnum PLY export functionality.

What StanfordImporter can do and Assimp can't is import of files with per-vertex semantic IDs. I remember that used to be used quite often, not sure if that's still relevant for current datasets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thoughts on this topic.
I don't think semantic ids in .ply are necessary for python import, but ASCII ply is an easy format for hand-edited or human-readable mesh data. Agreed we generally don't try to use these in practice.

@aclegg3 aclegg3 merged commit af817be into main May 16, 2023
@aclegg3 aclegg3 deleted the magnum-plugins-dependencies branch May 16, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants