Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewer.py - disable Simulator default agent navmesh override #2124

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jun 7, 2023

Motivation and Context

#2111 introduced default agent navmesh setup through settings.py. The viewer application already has logic for this and using the default agent settings will override SceneDataset configured navmeshes if the config is non-default. It should therefore be disabled in the app.

How Has This Been Tested

Local

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 7, 2023
@aclegg3 aclegg3 merged commit 19cce0d into main Jun 8, 2023
@aclegg3 aclegg3 deleted the py-viewer-no-auto-navmesh branch June 8, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants