Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[BE Week]Set lighting if loading an AO to match scene lighting. #2138

Merged
merged 1 commit into from
Jun 27, 2023
Merged

--[BE Week]Set lighting if loading an AO to match scene lighting. #2138

merged 1 commit into from
Jun 27, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This small PR sets the default lighting for an articulated object loaded into viewer to match the lighting currently specified in the scene being displayed.

How Has This Been Tested

Running viewer and loading AOs (spot specifically).

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 27, 2023
0mdc
0mdc approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jturner65 jturner65 changed the title --Set lighting if loading an AO to match scene lighting. --[BE Week]Set lighting if loading an AO to match scene lighting. Jun 27, 2023
@jturner65 jturner65 merged commit 30cf309 into main Jun 27, 2023
@jturner65 jturner65 deleted the viewer_aoLoad branch June 27, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @0mdc @facebook-github-bot