Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[BE Week]Modify ESP_CHECK to exit not abort. #2143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

--[BE Week]Modify ESP_CHECK to exit not abort. #2143

wants to merge 1 commit into from

Conversation

jturner65
Copy link
Contributor

Motivation and Context

Currently our ESP_CHECK macro was exiting the program via std::abort(), providing a core dump. However, it is most often used to verify data or check the results of file IO, for which a core dump is undesirable. This PR changes ESP_CHECK to std::exit(1) instead, avoiding the core dump.

An alternative mechanism that provides the assertion-like behavior with the std::abort/core dump functionality while also communicating with python properly is being investigated for a future PR.

How Has This Been Tested

All current c++ and python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested review from mosra, eundersander and 0mdc June 30, 2023 14:20
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 30, 2023
@jturner65 jturner65 requested a review from aclegg3 July 3, 2023 19:15
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 07a405e to 1b998f7 Compare July 6, 2023 10:06
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 4 times, most recently from d4a44be to 5892a01 Compare September 27, 2023 19:13
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from e8deb90 to a5c2fb0 Compare November 29, 2023 14:40
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 4 times, most recently from 83e06d3 to 3c6be66 Compare December 12, 2023 17:24
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 3a2fe6c to 5016d85 Compare January 4, 2024 13:52
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 94ac25a to 9f83102 Compare January 9, 2024 21:16
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 162c2aa to 09435f6 Compare January 29, 2024 19:22
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 1d05c99 to da65296 Compare February 5, 2024 14:07
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 4 times, most recently from 9d8a97f to 8bcb838 Compare May 8, 2024 14:14
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 3 times, most recently from a6d16aa to 4db7335 Compare May 13, 2024 18:50
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 38f3b51 to 1a3bce4 Compare June 18, 2024 13:51
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch from 1a3bce4 to 3f18c63 Compare June 20, 2024 14:44
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 3073266 to 6e98d6f Compare July 25, 2024 15:27
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from edfd813 to 257a5bc Compare August 13, 2024 14:00
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from c580f32 to 0e21e20 Compare August 25, 2024 15:47
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from 32f95fd to 383eec7 Compare September 5, 2024 12:58
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 3 times, most recently from 1c85ec0 to ea1e587 Compare September 18, 2024 17:17
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 2 times, most recently from ecec275 to e01682b Compare November 4, 2024 18:17
@jturner65 jturner65 force-pushed the BE_EspCheckRework branch 3 times, most recently from 966fb98 to c33b16b Compare November 13, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mosra mosra Awaiting requested review from mosra

@eundersander eundersander Awaiting requested review from eundersander

@0mdc 0mdc Awaiting requested review from 0mdc

@aclegg3 aclegg3 Awaiting requested review from aclegg3

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @Skylion007 @facebook-github-bot