Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump isort to 5.12.0. #2150

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Bump isort to 5.12.0. #2150

merged 1 commit into from
Jul 10, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jul 7, 2023

Motivation and Context

Bump isort to 5.12.0.
The dependency was previously pinned at 5.11.5 due to dropped support of Python 3.7. We have since upgraded Habitat's python version. See facebookresearch/habitat-lab#1107.

How Has This Been Tested

Tested on CI.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 7, 2023
@0mdc 0mdc requested a review from aclegg3 July 7, 2023 20:31
@0mdc 0mdc marked this pull request as ready for review July 7, 2023 20:31
@0mdc 0mdc requested a review from Skylion007 July 7, 2023 21:07
@0mdc 0mdc merged commit df2c96e into main Jul 10, 2023
@jturner65 jturner65 deleted the upgrade-isort branch July 10, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants