Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[BE Week]Remove files no longer used without Variance Shadow Maps #2154

Merged
merged 1 commit into from
Jul 11, 2023
Merged

--[BE Week]Remove files no longer used without Variance Shadow Maps #2154

merged 1 commit into from
Jul 11, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This class is no longer used or useful since we removed variance shadow maps in this PR

How Has This Been Tested

Existing c++ and python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested review from aclegg3 and 0mdc July 11, 2023 13:12
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 11, 2023
@jturner65 jturner65 merged commit fabedcd into main Jul 11, 2023
@jturner65 jturner65 deleted the BE_VarShadowMap2 branch July 11, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@0mdc 0mdc Awaiting requested review from 0mdc

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @aclegg3 @facebook-github-bot