Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug for directories containing spaces #2176

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

vishneshjr
Copy link
Contributor

@vishneshjr vishneshjr commented Aug 4, 2023

Motivation and Context

Previously the code would not work for directories containing spaces (due to a split function being called). This has now been fixed.

For example, if you try to run the command:
python -m habitat_sim.utils.datasets_download --uids habitat_test_scenes --data-path ./Data" from the directory: "/Users/vishnesh/Master/Sample Folder With Spaces", you get the following error.

How Has This Been Tested

This has been tested by reviewing how the path is split and by running the same command python -m habitat_sim.utils.datasets_download --uids habitat_test_scenes --data-path ./Data" without any errors.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • Would like some confirmation on whether the bug fix follows the code style or if something needs to be changed.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
    • (Not sure where to add tests for this bug fix.)
  • All new and existing tests passed.

Previously the code would not work for directories containing spaces due to the split function being called.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 4, 2023
@vishneshjr vishneshjr marked this pull request as draft August 4, 2023 07:55
@vishneshjr vishneshjr marked this pull request as ready for review August 4, 2023 07:56
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the problem when you found it. 🙂
Sorry for the review delay.

@aclegg3 aclegg3 merged commit 8534762 into facebookresearch:main Aug 17, 2023
1 check passed
@vishneshjr
Copy link
Contributor Author

No problem! I think I saw the same issue in some other places. I'll let you know if I find it elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants