Disable broken JS test and make --no-web-apps the default #2179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This javascript test is broken, probably just due to timing out. Habitat JS support is still experimental so it's not vital to have this JS tested for now. We'll revisit CI for the JS build in the future.
I'm also making
--no-web-apps
the default for the JS build. This is a simpler build that doesn't rely on npm or webpack and should make the Habitat JS build more accessible and easy to understand for new folks looking to experiment here.More background and specifics: the Habitat JS build is a version of our C++ library that is emscripten-compiled into a WebAssembly module (a
.wasm
file). This can be imported into a webpage and used by Javascript. Our legacy web apps (bindings.html, viewer.html) are examples of using the Habitat JS build, but they're not a required part of the JS build.How Has This Been Tested
Types of changes
Checklist