Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable broken JS test and make --no-web-apps the default #2179

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

eundersander
Copy link
Contributor

Motivation and Context

This javascript test is broken, probably just due to timing out. Habitat JS support is still experimental so it's not vital to have this JS tested for now. We'll revisit CI for the JS build in the future.

I'm also making --no-web-apps the default for the JS build. This is a simpler build that doesn't rely on npm or webpack and should make the Habitat JS build more accessible and easy to understand for new folks looking to experiment here.

More background and specifics: the Habitat JS build is a version of our C++ library that is emscripten-compiled into a WebAssembly module (a .wasm file). This can be imported into a webpage and used by Javascript. Our legacy web apps (bindings.html, viewer.html) are examples of using the Habitat JS build, but they're not a required part of the JS build.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 8, 2023
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you rebase this PR on top of main now, you should get a clean slate. (or just merge it, but it might be good to see if this exposes any other issues)

@jturner65 jturner65 force-pushed the eundersander/disable_legacy_javascript branch from 42b1d92 to e5194e0 Compare August 9, 2023 17:44
@jturner65
Copy link
Contributor

Took the liberty of rebasing this to test it, hopefully that's ok :)

@aclegg3
Copy link
Contributor

aclegg3 commented Aug 9, 2023

Took the liberty of rebasing this to test it, hopefully that's ok :)

Thanks, let's merge it ASAP once tests are done.

@jturner65 jturner65 merged commit edab124 into main Aug 9, 2023
1 check passed
@jturner65 jturner65 deleted the eundersander/disable_legacy_javascript branch August 9, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants