Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] - remove dummy sceneId from the API #2186

Merged
merged 2 commits into from
Aug 17, 2023
Merged

[BE] - remove dummy sceneId from the API #2186

merged 2 commits into from
Aug 17, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 16, 2023

Motivation and Context

Multi-scene dummy API has been around for awhile. Cleaning it up.

How Has This Been Tested

CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 16, 2023
@0mdc
Copy link
Contributor

0mdc commented Aug 16, 2023

Great stuff! Thanks for doing this!

Do we currently have a need for SceneManager?

@aclegg3
Copy link
Contributor Author

aclegg3 commented Aug 16, 2023

Do we currently have a need for SceneManager?

It plays a minor role currently in managing the distinction between the semantic and RGBD SceneGraphs, but I don't think we actually need it long term. In either case, that is separate enough to warrant it's own PR, so let's chat offline and consider it a follow-up.

@aclegg3 aclegg3 merged commit 84d0242 into main Aug 17, 2023
1 check passed
@aclegg3 aclegg3 deleted the remove-scene-id branch August 17, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants