-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--[WIP][BE/Refactor/Bugfix] Remove deprecated distutils from setup and ab_test #2202
Draft
jturner65
wants to merge
2
commits into
main
Choose a base branch
from
RemoveDistutilsFromSetup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Sep 13, 2023
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
September 14, 2023 16:50
adcd3bc
to
562580c
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
5 times, most recently
from
September 27, 2023 19:12
94b0634
to
7399bf4
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
3 times, most recently
from
October 12, 2023 13:21
7c7bdb4
to
246500f
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
October 26, 2023 15:28
e7c3f98
to
153c984
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
November 14, 2023 16:18
153c984
to
d0490ac
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
November 29, 2023 14:25
36750ac
to
a73637b
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
4 times, most recently
from
December 12, 2023 18:13
1d3155f
to
3139d0c
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
December 18, 2023 17:18
3139d0c
to
56298a4
Compare
Skylion007
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also bump the supported versions for our conda builds.
Latest version of pybind11 supports python 3.12. Also latest versions of torch will too now. |
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
January 4, 2024 13:52
a21bc23
to
f4075ad
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
January 9, 2024 21:16
f6767f7
to
46c8648
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
January 22, 2024 21:16
46c8648
to
a7727fc
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
May 13, 2024 18:49
4d31035
to
a4f746a
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
June 18, 2024 13:50
15049ff
to
36cb92d
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
June 20, 2024 14:33
36cb92d
to
bcb3992
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
July 25, 2024 15:27
708372c
to
693af4b
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
August 13, 2024 14:01
336955f
to
f39421a
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
August 25, 2024 15:46
f33e56e
to
73fae5e
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
September 5, 2024 12:57
6723fa4
to
4d8fed8
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
September 10, 2024 13:41
4d8fed8
to
d18eecb
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
September 17, 2024 14:25
d18eecb
to
46f1c11
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
September 18, 2024 17:16
b6a472d
to
36f2b91
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
October 29, 2024 21:10
36f2b91
to
9843784
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
November 11, 2024 16:04
ae91b20
to
d279d43
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
2 times, most recently
from
November 13, 2024 19:55
9ffa254
to
f2c33c8
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
November 25, 2024 19:40
f2c33c8
to
97835a0
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
December 4, 2024 15:18
97835a0
to
13231ea
Compare
jturner65
force-pushed
the
RemoveDistutilsFromSetup
branch
from
December 11, 2024 14:35
13231ea
to
759dafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Distutils is deprecated and will be removed in python 3.12, which is slated for release Oct 2 2023. This PR removes references to Distutils in HabitatSim python code. It does require the 'packaging' library, so this also needs to be added to requirements.txt. (@Skylion007 is there a better option than this to provide version classes?)
NOTE : Our versions of bullet, assimp and pybind11 all also have distutils references, so we may need to update these libraries before we can claim python 3.12 support. (magnum also does, but I'm sure mosra will address when appropriate).
How Has This Been Tested
Types of changes
Checklist