--Address HBAO image transparency oddness; remove unused variable. #2214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Image captures of scenes containing HBAO effect were demonstrating strange transparency-related artifacts due to the HBAO effect also being present in the alpha channel and an improper blend being performed. This PR addresses this by correcting the blend mechanism. New Test/ground truth images are also generated. Lastly, an unused value is removed.
How Has This Been Tested
C++ and python tests pass locally. New test images are synthesized to account for the new blend algorithm for the HBAO output framebuffer.
Types of changes
Checklist