Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BUGFIX] Minor bugfixes #2233

Merged
merged 6 commits into from
Oct 10, 2023
Merged

--[BUGFIX] Minor bugfixes #2233

merged 6 commits into from
Oct 10, 2023

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Oct 9, 2023

Motivation and Context

This PR fixes a few minor bugs and updates various comments.
Bugfixes :

  • When saving a Managed File-based Object (such as a SceneInstanceAttributes JSON file) and not wishing to overwrite an existing copy, Habitat sim generates a numbered suffix (copy xxxx) where xxxx will be an integer sequence starting at 0000 and incrementing for each copy saved. Currently on main branch, if such a copy is then loaded in a subsequent execution and then another copy is saved, and 2nd 'copy 0000' string is appended to the name. This PR fixes this, and instead properly increments the existing copy count in the name.
  • AttributesConfigsTest and AttributesManagersTest are modified to use the correct TEST_ASSETS test directory macro for file IO.
  • Unnecessary 'using' statements are also removed from various metadata managers.

Local C++ and python tests pass

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 9, 2023
@jturner65 jturner65 changed the title --[BUGFIX] Habitat3 bugfixes, doc improvements and comment updates --[BUGFIX] Habitat3 minor bugfixes Oct 9, 2023
@jturner65 jturner65 marked this pull request as ready for review October 9, 2023 18:18
@jturner65 jturner65 requested review from aclegg3 and 0mdc and removed request for aclegg3 October 9, 2023 18:18
@jturner65 jturner65 changed the title --[BUGFIX] Habitat3 minor bugfixes --[BUGFIX] Minor bugfixes Oct 9, 2023
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/esp/core/managedContainers/ManagedFileBasedContainer.h Outdated Show resolved Hide resolved
@jturner65 jturner65 merged commit 2ff5e18 into main Oct 10, 2023
10 checks passed
@jturner65 jturner65 deleted the Bugfixes_Hab3_DocsMetadata branch October 10, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants