Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rigs not being deleted from the recorder. #2251

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix rigs not being deleted from the recorder. #2251

merged 1 commit into from
Oct 25, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Oct 25, 2023 •
edited
Loading

Motivation and Context

A sneaky reference was causing the rigId to reset to the default value (-1) after the instance record was cleared, causing the removal from internal maps to fail.

How Has This Been Tested

Tested locally with the sandbox tool humanoid switching.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 25, 2023
eundersander
eundersander approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit 294c3fe into main Oct 25, 2023
6 of 10 checks passed
@0mdc 0mdc deleted the rig-deletion-bugfix branch October 25, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eundersander eundersander eundersander approved these changes

@jturner65 jturner65 jturner65 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0mdc @jturner65 @eundersander @facebook-github-bot