Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--Update reference to deprecated Magnum 'angle' function #2264

Merged
merged 1 commit into from
Nov 14, 2023
Merged

--Update reference to deprecated Magnum 'angle' function #2264

merged 1 commit into from
Nov 14, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

The Magnum::Math::angle() function has been renamed/deprecated in this PR. This PR addresses a leftover reference to the deprecated function call.

How Has This Been Tested

Locally all C++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 14, 2023
mosra
mosra approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry, missed those in #2243...

aclegg3
aclegg3 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jturner65 jturner65 merged commit edc9046 into main Nov 14, 2023
10 checks passed
@jturner65 jturner65 deleted the UpdateMagnumAngleCall branch November 14, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@mosra mosra mosra approved these changes

@0mdc 0mdc Awaiting requested review from 0mdc

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jturner65 @mosra @aclegg3 @facebook-github-bot