Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in python viewer. #2282

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Dec 15, 2023

Motivation and Context

This fixes an indentation errors in the python viewer that causes the batch renderer to execute multiple times. This is not an issue under normal usage.

How Has This Been Tested

Tested locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@0mdc 0mdc requested a review from jturner65 December 15, 2023 17:17
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 15, 2023
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Nice find.

@0mdc 0mdc merged commit 79a19eb into facebookresearch:main Dec 15, 2023
4 of 10 checks passed
@0mdc 0mdc deleted the viewer-batch-renderer-fix branch December 15, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants