-- [Part 1 of 2] Semantic Attributes Metadata : Support for Semantic Regions - Add attributes/config support #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
SemanticRegions
branch
4 times, most recently
from
3d6dd65
to
f74d89d
Compare
jturner65
force-pushed
the
SemanticRegions
branch
from
9d8321b
to
cf78260
Compare
jturner65
changed the title
…sts. HM3D and Replica still fail
HM3D is still not working.
Loading the default/path/configs tags out of order can cause very difficult to debug issues. They must be loaded in the given order.
TODO : need to add template bindings when format has been firmed up.
…string also adds binding
Added substring-search based retrieval.
jturner65
force-pushed
the
SemanticRegions
branch
from
9faaf57
to
c955b2e
Compare
aclegg3
approved these changes
Jan 22, 2024
| @@ -237,6 +239,15 @@ void declareBaseAttributesManager(py::module& m, | |||
| "if it does not.") | |||
| .c_str(), | |||
| "handle"_a) | |||
| .def("get_first_matching_template_by_handle", | |||
There was a problem hiding this comment.
Why introduce this instead of getting all matches and selecting the first like we do already? Doing that puts responsibility on user code to handle the case of multiple matches and offers the opportunity for an assertion.
There was a problem hiding this comment.
I was doing this to provide a shortcut for folks who know they are going to use the first handle they get back, so they didn't have to deal with querying the handles and then querying for the actual attributes. Seems like the first index tends to be the goto for this kind of process, and I thought I'd abstract it away. The other mechanism is still present.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR is part 1 of a 2 part changeset that adds support for semantic regions in a dataset-agnostic way through the use of the existing metadata subsystem tooling.
This component adds manager, attributes and JSON config support for semantic scene descriptions that include region annotations for poly-loop-based extrusion region definitions, integrated into the existing metadata subsystem, managed by the existing scene dataset handling and accessed during scene creation. This PR does not introduce any breaking changes to the existing system, but does expand the possible metadata loading/handling in the scene dataset configs for the "semantic_scene_descriptor_instances" tag.
Part 2 of this PR will use these configs to instantiate Semantic Regions with the appropriate geometry and location that will support point containment checks and debug rendering.
How Has This Been Tested
Existing c++ and python tests pass.
Types of changes
Checklist