Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[CI Fix] Fix miniconda versions #2334

Merged
merged 1 commit into from
Mar 5, 2024
Merged

--[CI Fix] Fix miniconda versions #2334

merged 1 commit into from
Mar 5, 2024

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Mar 5, 2024

Motivation and Context

Using the latest miniconda versions is referencing python 3.12 which is undesirable, and causes osx builds to break (pkgutil.ImpImporter class was deprecated in python 3.3 and removed in 3.12.)

This PR will freeze our miniconda version to most recent python 3.10 version for both linux and mac.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

latest miniconda is using python 3.12 which is undesirable, and causes osx builds to break.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 5, 2024
@jturner65 jturner65 changed the title --fix miniconda versions --[CI Fix] Fix miniconda versions Mar 5, 2024
@jturner65 jturner65 requested review from aclegg3, mosra and 0mdc March 5, 2024 15:29
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We'll probably want to extend support to Python 3.12 in the foreseeable future.

@jturner65
Copy link
Contributor Author

LGTM!

We'll probably want to extend support to Python 3.12 in the foreseeable future.

Yeah, definitely (supposed to be markedly faster with strings, for instance), but it will certainly require a some investigation and reworking since there are many modules that have been deprecated for a while that were removed with 3.11 and 3.12.

@aclegg3
Copy link
Contributor

aclegg3 commented Mar 5, 2024

Thanks for investigating and fixing this. 👍

@jturner65 jturner65 merged commit 498cae1 into main Mar 5, 2024
10 checks passed
@jturner65 jturner65 deleted the CI_miniconda_fix branch March 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants