Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove RTLD_GLOBAL flag from apps. (#2312) #2342

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 20, 2024

Motivation and Context

This reverts commit d890c64 (#2312), which is causing downstream issues (for instance, in habitat-llm).

The downstream issues will be stabilized prior to re-introducing this change.

How Has This Been Tested

N/A

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 20, 2024
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll have to revert this PR too for lab.

@0mdc
Copy link
Contributor Author

0mdc commented Mar 20, 2024

I guess we'll have to revert this PR too for lab.

No, it's not necessary.

The RTLD_GLOBAL magic is now done when doing import corrade (or magnum, which imports corrade).

@0mdc 0mdc merged commit 5f2bc6a into main Mar 20, 2024
9 of 10 checks passed
@0mdc 0mdc deleted the 0mdc/revert-remove-rtld-global branch March 20, 2024 13:51
0mdc added a commit that referenced this pull request Apr 23, 2024
0mdc added a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants