--Add Configuration State Flags - Part 2 (Hidden file path fields) #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jturner65
changed the title
jturner65
force-pushed
the
ConfigVals_Part2
branch
from
c9b39d0
to
7449748
Compare
These fields will hold the fully qualified file paths that we wish to consume internally but do not wish to write to disk.
Remove the path and have only relative filepath in primary handle attribute; put fully qualified version in hidden handle attribute. Still fails in some edge cases
This will obviate the need for registering a template before it can be used. Mainly going to be consumed by tests, which often bypass internal control-flow branches that would otherwise automatically register these modified templates.
When a path is set by the user via the path/handle attributes properties, the filter function will copy the fully qualified path to the appropriate read-only property and attempt to transform the path to be relative to the location of the owning dataset's path structure.
jturner65
force-pushed
the
ConfigVals_Part2
branch
from
7449748
to
dc3a209
Compare
If no collision asset was given the given render asset handles should be used.
aclegg3
approved these changes
May 23, 2024
jturner65
force-pushed
the
ConfigVals_Part2
branch
from
ded0cc1
to
72e4b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR is the 2nd of 2 PRs started with this PR that add state-based support to ConfigValues. This PR is primarily concerned with implementing hidden/internal configuration fields intended to be used for data that is only locally relevant, such as fully-qualified file paths.
We do not want file names saved to json that embed absolute path data, so we need to keep a version of the path data that remains relative to the location of the JSON config file while we also want to have an easily consumed absolute path to the assets in question. Using the hidden field feature, paths can be saved in the configs as they are loaded, or otherwise relative to the dataset config directory, while they can be accessed internally fully qualified.
How Has This Been Tested
Local c++ and python tests pass
Types of changes
Checklist