--Bugfix : Expand absolute-to-relative filepath mapping rigor #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filepath to be changed should also contain a filename
facebook-github-bot
added
the
CLA Signed
Dereferencing the iterator pointing at cend() is UB. Conda build segfaults right here, almost certainly from this issue. By moving the comparison of the values to after the location check for the iterators, hopefully the comparison will never happen if either iterator is at end.
aclegg3
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR addresses some edge case situations that might arise when absolute filepaths are made relative to other paths.
It also substantially expands the tests of this functionality.
How Has This Been Tested
Locally c++ and python tests pass
Types of changes
Checklist