Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] - reorder Configuration setter bindings #2401

Merged
merged 2 commits into from
May 31, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 30, 2024

Motivation and Context

Python seems to treat bindings as a dict or list and searches for the first matching override for a bound function. Python treats Bool as a subclass of Integer, so set(key, Bool) in Configuration was writing integers. Re-ordering the bindings fixes this.

How Has This Been Tested

Local testing and new python test case

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 May 30, 2024 19:31
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 30, 2024
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aclegg3 aclegg3 merged commit dd42b46 into main May 31, 2024
10 checks passed
@aclegg3 aclegg3 deleted the alex-05_30-bugfix_configuration_setter_order branch May 31, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants