Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ManagedArticulatedObject attribute for link_id to object_id map #2410

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jun 18, 2024

Motivation and Context

This PR adds link_ids_to_object_ids python property and getLinkIdsToObjectIds function to python and C++ ManagedArticulatedObject APIs respectfully.

We have had link_object_ids for while providing the opposite mapping. However, collision detection, raycasting, etc... opertate primarily on object_ids. If we want to know the object_id for a link in order to check it, we had to create an inverted map like:

links_to_obj_ids = {v: k for k, v in ao.link_object_ids.items()}

which is a pain.

How Has This Been Tested

Added a unit test for the maps in both directions.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested review from jturner65 and 0mdc June 18, 2024 22:06
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 18, 2024
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aclegg3 aclegg3 merged commit 5153e89 into main Jun 19, 2024
10 checks passed
@aclegg3 aclegg3 deleted the alex-06_18-ao_link_ids_to_object_ids_map branch June 19, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants