Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagedObject.getAabb() #2421

Merged
merged 11 commits into from
Jul 3, 2024
Merged

ManagedObject.getAabb() #2421

merged 11 commits into from
Jul 3, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jul 2, 2024

Motivation and Context

Adds a standard API function for querying the AABB of ManagedObjects.

In C++:

ManagedObject.getAabb()

In python (property):

obj.aabb

For ManagedArticulatedObjects, this function computes the cumulative bounding box from all the child links in the current state. A dirty flag is cached to ensure that re-computation effort is only applied when querying the property after a state change.

How Has This Been Tested

New tests are added to check that the function works for rigids with golden number and for AOs that all links are within the computed cumulative bounding box.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested review from jturner65 and 0mdc July 2, 2024 18:15
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 2, 2024
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question/suggestion

src_python/habitat_sim/simulator.py Outdated Show resolved Hide resolved
@aclegg3 aclegg3 merged commit a9917e6 into main Jul 3, 2024
8 of 10 checks passed
@aclegg3 aclegg3 deleted the alex-06_26-bb_utils branch July 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants