Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[CI BugFix] -Change circle CI mac conda install from intel mac to m1. #2445

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

CI dropped support for intel mac this past June, so we need to use miniconda for M1.

How Has This Been Tested

Execution on CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 9, 2024
@jturner65 jturner65 requested review from aclegg3 and 0mdc August 9, 2024 18:47
@jturner65 jturner65 changed the title --[CI BugFix] -Change circle cI mac conda install from intel mac to m1. --[CI BugFix] -Change circle CI mac conda install from intel mac to m1. Aug 9, 2024
gitkraken git client complaint.
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jturner65 jturner65 merged commit 4f34aef into main Aug 9, 2024
1 of 4 checks passed
@jturner65 jturner65 deleted the CI_FixMacCondaBuild branch August 9, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants