Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Update/cleanup gitignore #2458

Merged
merged 1 commit into from
Aug 26, 2024
Merged

--Update/cleanup gitignore #2458

merged 1 commit into from
Aug 26, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

Small update to git ignore :

  • Remove ancient references to semantic test assets
  • Reorganize /data/ ignore pattern - ignore everything in data except currently specified directories and files. This is to facilitate development, while also requiring any additions to the /data/` to be explicitly specified (since data should be accessed via the downloader and stored elsewhere)
  • Add ignore for local src/test/configure.h shortcut for gitkraken users :) (which does not support .git/info/exclude specifications)

How Has This Been Tested

Via git access

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 25, 2024
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jturner65 jturner65 merged commit 6ce858e into main Aug 26, 2024
10 checks passed
@jturner65 jturner65 deleted the update-gitignore branch August 26, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants