Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove matplotlib from conda requirements. #2520

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Dec 11, 2024

Motivation and Context

This changeset removes the matplotlib dependency from the conda build requirements.
This dependency includes many others that are likely to conflict with an environment.

How Has This Been Tested

N/A

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 11, 2024
@aclegg3
Copy link
Contributor

aclegg3 commented Dec 11, 2024

For context, the only imports of matplotlib in our code are for displaying sensor images in plots for the tutotials like here:


These can probably just be replaced by Pillow image show commands and related utils to remove matplotlib entirely.

This refactor can be a follow-up to removing the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants