Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Enable override of default Attributes Registration checks #928

Conversation

jturner65
Copy link
Contributor

Motivation and Context

Currently to register an object or stage attributes the specified render asset handle must exist, either as a valid object on disk, a valid existing primitive, or (in the case of a stage) be "none". If none of these conditions are true, the registration will fail and the attributes will not be added to the attributesManager library. This is useful in case errors exist in the attributes, so that object creation does not fail due to misnamed target assets.

The ability to override registration checks for object and stage attributes checks is useful for when render assets are computationally/"hand" crafted meshes. This PR adds a boolean argument to the registration process that allows for overriding the non-existing asset failure with a warning.

The default behavior will be to fail if specified render handle does not correspond to a known/knowable asset.

How Has This Been Tested

C++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 changed the title --Initial Commit --Enable override of default Attributes Registration checks Nov 10, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 10, 2020
@jturner65 jturner65 merged commit 0c65fe6 into facebookresearch:master Nov 10, 2020
@jturner65 jturner65 deleted the MM_AddSupportForRegistrationOverride branch November 10, 2020 20:32
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
…research#928)

* --Initial Commit

* --clang-tidy complaints

* --clang-format

* --Missed a clang tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants