Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: chore(falcosidekick): Values and config Update #378

Closed
wants to merge 16 commits into from

Conversation

Lowaiz
Copy link
Contributor

@Lowaiz Lowaiz commented Jul 26, 2022

What type of PR is this?

/kind feature

/kind chart-release

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

PR in prevision of FalcoSidekick version bump to 2.27.0.
Updating Chart for PRs:
falcosecurity/falcosidekick#336
falcosecurity/falcosidekick#337
falcosecurity/falcosidekick#338
falcosecurity/falcosidekick#341
falcosecurity/falcosidekick#346
falcosecurity/falcosidekick#347
falcosecurity/falcosidekick#349
falcosecurity/falcosidekick#353
falcosecurity/falcosidekick#356
falcosecurity/falcosidekick#359
falcosecurity/falcosidekick#360
falcosecurity/falcosidekick#362
falcosecurity/falcosidekick#366

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Do not merge this now.

/do-not-merge

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/feature New feature or request dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped labels Jul 26, 2022
@poiana
Copy link
Contributor

poiana commented Jul 26, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Lowaiz
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval by writing /assign @cpanato in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from bencer and nestorsalceda July 26, 2022 09:21
@poiana poiana added the size/M label Jul 26, 2022
@Lowaiz Lowaiz changed the title chore(falcosidekick): Values and config Update WIP: chore(falcosidekick): Values and config Update Jul 26, 2022
@Lowaiz
Copy link
Contributor Author

Lowaiz commented Jul 26, 2022

/area falcosidekick-chart

@Issif
Copy link
Member

Issif commented Jul 26, 2022

Thanks for your PR, as more changes may come before the next release of Sidekick, let's keep it opened and I will ask you to add them in future

@Lowaiz Lowaiz force-pushed the feat/sidekick_update branch from b9cd593 to 855ca86 Compare July 26, 2022 09:27
@poiana poiana added size/L and removed size/M labels Jul 26, 2022
@Lowaiz Lowaiz force-pushed the feat/sidekick_update branch from 67ba1a4 to 9f498fe Compare July 26, 2022 10:14
@Lowaiz
Copy link
Contributor Author

Lowaiz commented Jul 26, 2022

@Issif
Everything in the 2.27 Milestone of the sidekick has now its config here
(The fail in the CI is normal, it can't pull the 2.27 version of the sidekick)

@Lowaiz Lowaiz force-pushed the feat/sidekick_update branch 4 times, most recently from 44ece90 to 79bc3ff Compare July 27, 2022 14:31
@Issif
Copy link
Member

Issif commented Jul 27, 2022

Following this PR falcosecurity/falcosidekick#346 we need now to export the env var NAMESPACE in all Falcosidekick pods, can you add it following this snippet please:

 - name: NAMESPACE
   valueFrom:
     fieldRef:
       fieldPath: metadata.namespace

@alacuku
Copy link
Member

alacuku commented Jul 27, 2022

Hi @Lowaiz, for the falco chart we came up with a solution to keep updated the values table. It uses the helm-docs that combined with a makefile generates an updated values table from the comments in the values.yaml file. Here you can find the commit that introduced helm-docs in falco: 3583076.
It would be nice to implement the same solution for falcosidekick! Let me know what you think.

@Lowaiz
Copy link
Contributor Author

Lowaiz commented Jul 27, 2022

It would be nice to implement the same solution for falcosidekick!

Could be great, I'll take a look at that tomorrow.

@Lowaiz
Copy link
Contributor Author

Lowaiz commented Jul 28, 2022

@alacuku #384

Lowaiz added 4 commits July 29, 2022 18:10
feat(alertmanager-extra-fields): Updates values and secrets for AlertManager extra labels and annotations.

In prevision of sidekick version bump.
falcosecurity/falcosidekick#341
falcosecurity/falcosidekick#347

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
…treams

In prevision of sidekick version bump.
falcosecurity/falcosidekick#336

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
In prevision of sidekick version bump.
falcosecurity/falcosidekick#337

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
In prevision of sidekick version bump.
falcosecurity/falcosidekick#338

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Lowaiz added 3 commits July 29, 2022 18:10
In prevision of sidekick version bump.
falcosecurity/falcosidekick#349

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
In prevision of sidekick version bump.
falcosecurity/falcosidekick#346

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
@Lowaiz Lowaiz force-pushed the feat/sidekick_update branch from f40b7da to 0fbada2 Compare July 29, 2022 16:22
Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Lowaiz added 8 commits August 8, 2022 10:15
…falcosidekick#353

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
…falcosidekick#356

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
…elds

from falcosecurtiy/falcosidekick#356

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
…ption

from falcosecurtiy/falcosidekick#366

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
from falcosecurtiy/falcosidekick#362

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
from falcosecurtiy/falcosidekick#359

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
from falcosecurtiy/falcosidekick#360

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
@poiana
Copy link
Contributor

poiana commented Dec 12, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Jan 11, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@Issif
Copy link
Member

Issif commented Jan 11, 2023

I released the new versions and updated the charts. I co-authored you of course. Thanks.

@Issif Issif closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants