Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Yandex Data Streams support #336

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Adding Yandex Data Streams support #336

merged 1 commit into from
Jun 22, 2022

Conversation

preved911
Copy link
Contributor

Hello. This PR will allow using Yandex Data Streams for output. Can it be merged, please?

@poiana
Copy link

poiana commented Jun 20, 2022

@preved911: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented Jun 20, 2022

Welcome @preved911! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana requested review from fjogeleit and nibalizer June 20, 2022 13:25
@poiana poiana added the size/M label Jun 20, 2022
@preved911 preved911 force-pushed the feature/add_yandex_data_streams_support branch from 90f1a4b to 64fd7e1 Compare June 20, 2022 13:25
@preved911 preved911 mentioned this pull request Jun 20, 2022
Closed
@preved911
Copy link
Contributor Author

/assign @leodido

Issif
Issif reviewed Jun 20, 2022
View reviewed changes
types/types.go Outdated Show resolved Hide resolved
Issif
Issif reviewed Jun 20, 2022
View reviewed changes
README.md Show resolved Hide resolved
@preved911 preved911 force-pushed the feature/add_yandex_data_streams_support branch 2 times, most recently from 711a722 to e08fec7 Compare June 20, 2022 16:31
@poiana poiana added size/L and removed size/M labels Jun 20, 2022
@preved911 preved911 force-pushed the feature/add_yandex_data_streams_support branch from e08fec7 to e24646b Compare June 20, 2022 16:32
@preved911 preved911 requested a review from Issif June 20, 2022 16:47
Issif
Issif reviewed Jun 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@preved911 preved911 force-pushed the feature/add_yandex_data_streams_support branch from e24646b to badbe35 Compare June 20, 2022 17:22
@preved911 preved911 requested a review from Issif June 20, 2022 17:55
Issif
Issif reviewed Jun 21, 2022
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good except for the stats, a line like this is missing

@preved911
added Yandex Data Streams support
5879d22 
Signed-off-by: Ildar Valiullin <preved.911@gmail.com>
@preved911 preved911 force-pushed the feature/add_yandex_data_streams_support branch from badbe35 to 5879d22 Compare June 21, 2022 17:25
@preved911 preved911 requested a review from Issif June 21, 2022 17:27
@preved911
Copy link
Contributor Author

It seems good except for the stats, a line like this is missing

Please check it again

Issif
Issif approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana added the lgtm label Jun 22, 2022
@poiana
Copy link

poiana commented Jun 22, 2022

LGTM label has been added.

Git tree hash: 3275aa019d0842793e6357a38738b9956a2120fc

@poiana
Copy link

poiana commented Jun 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, preved911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 503b96a into falcosecurity:master Jun 22, 2022
@Issif Issif added this to the 2.27.0 milestone Jun 22, 2022
Lowaiz added a commit to Lowaiz/charts that referenced this pull request Jul 26, 2022
@Lowaiz
feat(yandex-datastreams): Updates values and secrets for Yandex datas…
423a626 
…treams

In prevision of sidekick version bump.
falcosecurity/falcosidekick#336

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Lowaiz added a commit to Lowaiz/charts that referenced this pull request Jul 29, 2022
@Lowaiz
feat(yandex-datastreams): Updates values and secrets for Yandex datas…
ab59bb7 
…treams

In prevision of sidekick version bump.
falcosecurity/falcosidekick#336

Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
@Lowaiz Lowaiz mentioned this pull request Sep 13, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Issif Issif Issif approved these changes

@fjogeleit fjogeleit Awaiting requested review from fjogeleit

@nibalizer nibalizer Awaiting requested review from nibalizer

Assignees

@leodido leodido

@Issif Issif

Labels
approved dco-signoff: yes lgtm needs-kind size/L
Projects
Falcosidekick 2.x
Status: Done
Milestone
2.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@preved911 @poiana @Issif @leodido