Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): update libs and driver to latest master #3413

Closed
wants to merge 4 commits into from

Conversation

github-actions[bot]
Copy link

This PR updates libs and driver to latest commit.
/kind release
/area build

NONE

@poiana
Copy link
Contributor

poiana commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign incertum for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Nov 25, 2024

Closing and reopening to trigger CI.
/close

@poiana poiana closed this Nov 25, 2024
@poiana
Copy link
Contributor

poiana commented Nov 25, 2024

@FedeDP: Closed this PR.

In response to this:

Closing and reopening to trigger CI.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP
Copy link
Contributor

FedeDP commented Nov 25, 2024

/reopen

@poiana poiana reopened this Nov 25, 2024
@poiana
Copy link
Contributor

poiana commented Nov 25, 2024

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP
Copy link
Contributor

FedeDP commented Nov 25, 2024

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Nov 25, 2024
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@FedeDP
Copy link
Contributor

FedeDP commented Dec 2, 2024

/close

@poiana poiana closed this Dec 2, 2024
@poiana
Copy link
Contributor

poiana commented Dec 2, 2024

@FedeDP: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP
Copy link
Contributor

FedeDP commented Dec 2, 2024

/reopen

@poiana poiana reopened this Dec 2, 2024
@poiana
Copy link
Contributor

poiana commented Dec 2, 2024

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP
Copy link
Contributor

FedeDP commented Dec 2, 2024

Added a commit to test HEAD of falcosecurity/libs#2177, to check if that actually fixes the tests here (it should :D ).
Will remove my commit once i tested that it is ok.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link
Contributor

poiana commented Dec 2, 2024

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@FedeDP
Copy link
Contributor

FedeDP commented Dec 2, 2024

Closing this PR! We spot the bug; it is indeed a wrong assert in the testing framework that casually worked until falcosecurity/libs#2165 got merged: falcosecurity/testing#66

@FedeDP
Copy link
Contributor

FedeDP commented Dec 2, 2024

/close

@poiana poiana closed this Dec 2, 2024
@poiana
Copy link
Contributor

poiana commented Dec 2, 2024

@FedeDP: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants