cleanup(tests): remove wrong/unused assert. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
|
/hold |
FedeDP
force-pushed
the
remove_useless_asser
branch
from
708f66e to
8605ecc
Compare
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
remove_useless_asser
branch
from
8605ecc to
a4af8b6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
falcosecurity/libs#2165 exposed a bug in the
TestFalco_Legacy_FalcoEventGeneratortest.Previous code was storing full user/group info in threadinfo; before parsers understood that container_id was changed (ie: we entered a container),
set_{user,group}was called (eg here: https://github.com/falcosecurity/libs/blob/master/userspace/libsinsp/parsers.cpp#L1769), storing in the threadinfo user and group information related to uid and gid for the host. Then, when refreshing info for the container(https://github.com/falcosecurity/libs/blob/master/userspace/libsinsp/parsers.cpp#L1843), since the container data cannot be loaded while replaying a scap file, and since the scap file itself does not containeruseraddedevents (being too old), we did not overwrite existing user/group info stored in the threadinfo.Therefore the threadinfo was returning user and group releted info mapped to the host while being on a container.
The new code fixed that behavior but then the test fails. Since we have no way to retrieve the correctly mapped-to-the-container user and group info while replaying a scap file that has no
useraddedevents, we can only remove the assert.