add Google Cloud Functions output type #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
reviewed
May 20, 2021
developer-guy
force-pushed
the
master
branch
2 times, most recently
from
fe69b95 to
72022c6
Compare
|
@developer-guy I'll try to take a look at it tonight/tomorrow. Looking forward to giving this a try :) |
Issif
requested changes
May 20, 2021
|
Looks good! Awesome work @developer-guy !! |
developer-guy
changed the title
Issif
changed the title
Issif
previously approved these changes
May 21, 2021
|
LGTM label has been added. Git tree hash: 9f532b146da87331e293f96e0abc12180b938c40
|
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
|
/kind feature |
Issif
approved these changes
May 22, 2021
|
LGTM label has been added. Git tree hash: eefe4d4d1c84950363a21ded9a39f1d66bd321cd
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
I thought that it would be nice if we have support for Cloud Function as an output type within the Falcosidekick.
Which issue(s) this PR fixes:
Fixes #240
Special notes for your reviewer: