Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver/bpf): add missing builtins.h to the install files list #38

Merged
merged 1 commit into from
May 6, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented May 5, 2021

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

What this PR does / why we need it:

builtins.h was recently added and it's required to build the bpf probe.

So, just add the missing file to the cmake install command.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr requested review from gnosek, leodido and fntlnz May 5, 2021 15:30
@poiana
Copy link
Contributor

poiana commented May 5, 2021

LGTM label has been added.

Git tree hash: b18bac8195810745edc4700eef405d960e050d79

@leogr
Copy link
Member Author

leogr commented May 5, 2021

/ok-to-test

@leogr
Copy link
Member Author

leogr commented May 6, 2021

/approve

@poiana poiana added the approved label May 6, 2021
@leodido
Copy link
Member

leodido commented May 6, 2021

/approve

@poiana
Copy link
Contributor

poiana commented May 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member Author

leogr commented May 6, 2021

/check-dco

@poiana poiana merged commit dcf8d6a into master May 6, 2021
@poiana poiana deleted the fix/bpf-install-files branch May 6, 2021 08:58
leogr pushed a commit to leogr/libs that referenced this pull request Jan 5, 2023
…alcosecurity#38)

such messages might end up flooding kernel logs.
Silence them unless the "verbose" module parameter is enabled.
Also, add information about the consumer.

Signed-off-by: Gerlando Falauto <gerlando.falauto@sysdig.com>
LucaGuerra pushed a commit to LucaGuerra/libs that referenced this pull request May 16, 2023
…alcosecurity#38)

such messages might end up flooding kernel logs.
Silence them unless the "verbose" module parameter is enabled.
Also, add information about the consumer.

Signed-off-by: Gerlando Falauto <gerlando.falauto@sysdig.com>
Andreagit97 pushed a commit to Andreagit97/libs that referenced this pull request Jun 1, 2023
…alcosecurity#38)

such messages might end up flooding kernel logs.
Silence them unless the "verbose" module parameter is enabled.
Also, add information about the consumer.

Signed-off-by: Gerlando Falauto <gerlando.falauto@sysdig.com>
mattnite pushed a commit to mattnite/falcosecurity-libs that referenced this pull request Oct 3, 2023
…alcosecurity#38)

such messages might end up flooding kernel logs.
Silence them unless the "verbose" module parameter is enabled.
Also, add information about the consumer.

Signed-off-by: Gerlando Falauto <gerlando.falauto@sysdig.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants