Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serde on Offer and PublicOffer structs #178

Closed
h4sh3d opened this issue Nov 17, 2021 · 1 comment · Fixed by #259
Closed

Add serde on Offer and PublicOffer structs #178

h4sh3d opened this issue Nov 17, 2021 · 1 comment · Fixed by #259
Labels
duplicate This issue or pull request already exists enhancement New feature or request mainnet priority
Milestone
v0.5.0

Comments

@h4sh3d
Copy link
Member

h4sh3d commented Nov 17, 2021

Serde is used in the node to display data in yaml format, having serde on all user facing structure is necessary.
@h4sh3d
Copy link
Member Author

h4sh3d commented Jun 7, 2022

Same as #240

@TheCharlatan TheCharlatan mentioned this issue Jun 16, 2022
Closed
@h4sh3d h4sh3d added duplicate This issue or pull request already exists enhancement New feature or request mainnet priority labels Jun 17, 2022
@h4sh3d h4sh3d added this to the v0.5.0 milestone Jul 1, 2022
h4sh3d added a commit to h4sh3d/farcaster-core that referenced this issue Jul 11, 2022
@h4sh3d
feat: add serde for Offer and PublicOffer types
3897238 
Fix farcaster-project#178.
@h4sh3d h4sh3d mentioned this issue Jul 11, 2022
Merged
h4sh3d added a commit to h4sh3d/farcaster-core that referenced this issue Jul 11, 2022
@h4sh3d
feat: add serde for Offer and PublicOffer types
10a0b51 
Fix farcaster-project#178.
h4sh3d added a commit to h4sh3d/farcaster-core that referenced this issue Jul 11, 2022
@h4sh3d
feat: add serde for Offer and PublicOffer types
f6680ec 
Fix farcaster-project#178.
TheCharlatan pushed a commit that referenced this issue Jul 11, 2022
@h4sh3d
feat: add serde on missing structs (#259)
db81e0a 
* feat: add serde on protocol parameters

Fix #80

* feat: add serde for Offer and PublicOffer types

Fix #178.

* feat: impl serde on missing protocol messages

* feat: add serde on TxLabel

* feat: serde btc fee with unit type 'sat/vByte'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists enhancement New feature or request mainnet priority
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

feat: add serde on missing structs h4sh3d/farcaster-core
1 participant
@h4sh3d