Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mapping from SwapId to Offer information #458

Closed
TheCharlatan opened this issue Jun 1, 2022 · 3 comments · Fixed by #524
Closed

Add a mapping from SwapId to Offer information #458

TheCharlatan opened this issue Jun 1, 2022 · 3 comments · Fixed by #524
Assignees
@TheCharlatan
Labels
enhancement New feature or request mainnet priority This should be prioritized

Comments

@TheCharlatan
Copy link
Member

Towards fulfilling the requirements of #258 it should be possible to retrieve information that was originally part of the offer (e.g. exchange rate, counterparty, thresholds, etc.) from a running swap.
@TheCharlatan TheCharlatan mentioned this issue Jun 7, 2022
Closed
@TheCharlatan TheCharlatan added enhancement New feature or request priority This should be prioritized mainnet labels Jun 16, 2022
@TheCharlatan
Copy link
Member Author

This is dependent on farcaster-project/farcaster-core#178 - adding serde to the Offer and PubOffer structs.

@zkao
Copy link
Member

zkao commented Jun 22, 2022

farcasterd/runtime struct contains consumed_offers

consumed_offers: HashMap<OfferId, (SwapId, ServiceId)>

Not what you are asking for, but close enough

@TheCharlatan TheCharlatan self-assigned this Jun 26, 2022
@TheCharlatan
Copy link
Member Author

Mapping added as part of #512

@TheCharlatan TheCharlatan linked a pull request Jun 29, 2022 that will close this issue
Offer history #512
Merged
@TheCharlatan TheCharlatan removed a link to a pull request Jun 30, 2022
Offer history #512
Merged
@TheCharlatan TheCharlatan mentioned this issue Jul 3, 2022
Merged
@zkao zkao closed this as completed in #524 Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCharlatan TheCharlatan

Labels
enhancement New feature or request mainnet priority This should be prioritized
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Swap: Add public offer to GetInfo TheCharlatan/farcaster-node
2 participants
@TheCharlatan @zkao