Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap: Add public offer to GetInfo #524

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

TheCharlatan
Copy link
Member

@TheCharlatan TheCharlatan commented Jul 3, 2022

Adds a public_offer to each swap state. Not sure if the swap state is the correct place to put it, as opposed to the Runtime, would be great to get your comment on this @zkao.

Also cleans up the swap GetInfo struct a bit.

Closes #458

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #524 (b7fcc41) into main (48c9de5) will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@          Coverage Diff          @@
##            main    #524   +/-   ##
=====================================
  Coverage   12.1%   12.1%           
=====================================
  Files         34      34           
  Lines      10290   10268   -22     
=====================================
  Hits        1241    1241           
+ Misses      9049    9027   -22     
Impacted Files Coverage Δ
src/rpc/request.rs 17.8% <0.0%> (+<0.1%) ⬆️
src/swapd/runtime.rs 0.0% <0.0%> (ø)
src/swapd/swap_state.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c9de5...b7fcc41. Read the comment docs.

@zkao
Copy link
Member

zkao commented Jul 3, 2022

Not sure if the swap state is the correct place to put it, as opposed to the Runtime, would be great to get your comment on this @zkao.

i would put this straight up on the runtime, because its not state machine related

@TheCharlatan
Copy link
Member Author

i would put this straight up on the runtime, because its not state machine related
Done.

Copy link
Member

@zkao zkao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zkao zkao merged commit 54106bc into farcaster-project:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a mapping from SwapId to Offer information
3 participants