-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for New Relic OTLP endpoint #786
Conversation
Ran Note that this endpoint should only be used for VCL services, so did not add any support/testing for creating Compute services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for re-opening this PR! The CI job passes now which is great 👍🏻
I have a few requested changes please.
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
* inlined some functions for readability * removed some compute specific code (e.g pruning VCL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mdenomy for this PR (and your patience waiting for a final review). All looks good to me 👍🏻
Adds support for the New Relic OTLP logging endpoint