Support for New Relic OTLP endpoint #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran Note that this endpoint should only be used for VCL services, so did not add any support/testing for creating Compute services |
Integralist
requested changes
Dec 7, 2023
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
* inlined some functions for readability * removed some compute specific code (e.g pruning VCL)
Integralist
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Thanks @mdenomy for this PR (and your patience waiting for a final review). All looks good to me 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the New Relic OTLP logging endpoint