Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for New Relic OTLP endpoint #786

Merged
merged 3 commits into from
Jan 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions docs/resources/service_vcl.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ $ terraform import fastly_service_vcl.demo xxxxxxxxxxxxxxxxxxxx@2
- `logging_loggly` (Block Set) (see [below for nested schema](#nestedblock--logging_loggly))
- `logging_logshuttle` (Block Set) (see [below for nested schema](#nestedblock--logging_logshuttle))
- `logging_newrelic` (Block Set) (see [below for nested schema](#nestedblock--logging_newrelic))
- `logging_newrelicotlp` (Block Set) (see [below for nested schema](#nestedblock--logging_newrelicotlp))
- `logging_openstack` (Block Set) (see [below for nested schema](#nestedblock--logging_openstack))
- `logging_papertrail` (Block Set) (see [below for nested schema](#nestedblock--logging_papertrail))
- `logging_s3` (Block Set) (see [below for nested schema](#nestedblock--logging_s3))
Expand Down Expand Up @@ -902,6 +903,24 @@ Optional:
- `response_condition` (String) The name of the condition to apply.


<a id="nestedblock--logging_newrelicotlp"></a>
### Nested Schema for `logging_newrelicotlp`

Required:

- `name` (String) The unique name of the New Relic OTLP logging endpoint. It is important to note that changing this attribute will delete and recreate the resource
- `token` (String, Sensitive) The Insert API key from the Account page of your New Relic account

Optional:

- `format` (String) Apache style log formatting. Your log must produce valid JSON that New Relic OTLP can ingest.
- `format_version` (Number) The version of the custom logging format used for the configured endpoint. Can be either `1` or `2`. (default: `2`).
- `placement` (String) Where in the generated VCL the logging call should be placed.
- `region` (String) The region that log data will be sent to. Default: `US`
- `response_condition` (String) The name of the condition to apply.
- `url` (String) The optional New Relic Trace Observer URL to stream logs to for Infinite Tracing.


<a id="nestedblock--logging_openstack"></a>
### Nested Schema for `logging_openstack`

Expand Down
243 changes: 243 additions & 0 deletions fastly/block_fastly_service_logging_newrelicotlp.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,243 @@
package fastly

import (
"context"
"fmt"
"log"

gofastly "github.com/fastly/go-fastly/v8/fastly"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

// NewRelicOTLPServiceAttributeHandler provides a base implementation for ServiceAttributeDefinition.
type NewRelicOTLPServiceAttributeHandler struct {
*DefaultServiceAttributeHandler
}

// NewServiceLoggingNewRelicOTLP returns a new resource.
func NewServiceLoggingNewRelicOTLP(sa ServiceMetadata) ServiceAttributeDefinition {
return ToServiceAttributeDefinition(&NewRelicOTLPServiceAttributeHandler{
&DefaultServiceAttributeHandler{
key: "logging_newrelicotlp",
serviceMetadata: sa,
},
})
}

// Key returns the resource key.
func (h *NewRelicOTLPServiceAttributeHandler) Key() string {
return h.key
}

// GetSchema returns the resource schema.
func (h *NewRelicOTLPServiceAttributeHandler) GetSchema() *schema.Schema {
blockAttributes := map[string]*schema.Schema{
"format": {
Type: schema.TypeString,
Optional: true,
Description: "Apache style log formatting. Your log must produce valid JSON that New Relic OTLP can ingest.",
},
"format_version": {
Type: schema.TypeInt,
Optional: true,
Default: 2,
Description: "The version of the custom logging format used for the configured endpoint. Can be either `1` or `2`. (default: `2`).",
ValidateDiagFunc: validateLoggingFormatVersion(),
},
"name": {
Type: schema.TypeString,
Required: true,
Description: "The unique name of the New Relic OTLP logging endpoint. It is important to note that changing this attribute will delete and recreate the resource",
},
"placement": {
Type: schema.TypeString,
Optional: true,
Description: "Where in the generated VCL the logging call should be placed.",
ValidateDiagFunc: validateLoggingPlacement(),
},
"region": {
Type: schema.TypeString,
Optional: true,
Default: "US",
Description: "The region that log data will be sent to. Default: `US`",
},
"response_condition": {
Type: schema.TypeString,
Optional: true,
Description: "The name of the condition to apply.",
},
"token": {
Type: schema.TypeString,
Required: true,
Sensitive: true,
Description: "The Insert API key from the Account page of your New Relic account",
},
"url": {
Type: schema.TypeString,
Optional: true,
Description: "The optional New Relic Trace Observer URL to stream logs to for Infinite Tracing.",
},
}

return &schema.Schema{
Type: schema.TypeSet,
Optional: true,
Elem: &schema.Resource{
Schema: blockAttributes,
},
}
}

// Create creates the resource.
func (h *NewRelicOTLPServiceAttributeHandler) Create(_ context.Context, d *schema.ResourceData, resource map[string]any, serviceVersion int, conn *gofastly.Client) error {
opts := h.buildCreate(resource, d.Id(), serviceVersion)

log.Printf("[DEBUG] Fastly New Relic OTLP logging addition opts: %#v", opts)

_, err := conn.CreateNewRelicOTLP(opts)
return err
}

// Read refreshes the resource.
func (h *NewRelicOTLPServiceAttributeHandler) Read(_ context.Context, d *schema.ResourceData, _ map[string]any, serviceVersion int, conn *gofastly.Client) error {
localState := d.Get(h.GetKey()).(*schema.Set).List()

if len(localState) > 0 || d.Get("imported").(bool) || d.Get("force_refresh").(bool) {
log.Printf("[DEBUG] Refreshing New Relic OTLP logging endpoints for (%s)", d.Id())
remoteState, err := conn.ListNewRelicOTLP(&gofastly.ListNewRelicOTLPInput{
ServiceID: d.Id(),
ServiceVersion: serviceVersion,
})
if err != nil {
return fmt.Errorf("error looking up New Relic OTLP logging endpoints for (%s), version (%v): %s", d.Id(), serviceVersion, err)
}

dll := flattenNewRelicOTLP(remoteState)

if err := d.Set(h.GetKey(), dll); err != nil {
log.Printf("[WARN] Error setting New Relic OTLP logging endpoints for (%s): %s", d.Id(), err)
}
}

return nil
}

// Update updates the resource.
func (h *NewRelicOTLPServiceAttributeHandler) Update(_ context.Context, d *schema.ResourceData, resource, modified map[string]any, serviceVersion int, conn *gofastly.Client) error {
opts := gofastly.UpdateNewRelicOTLPInput{
ServiceID: d.Id(),
ServiceVersion: serviceVersion,
Name: resource["name"].(string),
}

// NOTE: When converting from an interface{} we lose the underlying type.
// Converting to the wrong type will result in a runtime panic.
if v, ok := modified["token"]; ok {
opts.Token = gofastly.String(v.(string))
}
if v, ok := modified["format"]; ok {
opts.Format = gofastly.String(v.(string))
}
if v, ok := modified["format_version"]; ok {
opts.FormatVersion = gofastly.Int(v.(int))
}
if v, ok := modified["response_condition"]; ok {
opts.ResponseCondition = gofastly.String(v.(string))
}
if v, ok := modified["placement"]; ok {
opts.Placement = gofastly.String(v.(string))
}
if v, ok := modified["region"]; ok {
opts.Region = gofastly.String(v.(string))
}
if v, ok := modified["url"]; ok {
opts.URL = gofastly.String(v.(string))
}

log.Printf("[DEBUG] Update New Relic OTLP Opts: %#v", opts)
_, err := conn.UpdateNewRelicOTLP(&opts)
if err != nil {
return err
}
return nil
}

// Delete deletes the resource.
func (h *NewRelicOTLPServiceAttributeHandler) Delete(_ context.Context, d *schema.ResourceData, resource map[string]any, serviceVersion int, conn *gofastly.Client) error {
opts := &gofastly.DeleteNewRelicOTLPInput{
ServiceID: d.Id(),
ServiceVersion: serviceVersion,
Name: resource["name"].(string),
}

log.Printf("[DEBUG] Fastly New Relic OTLP logging endpoint removal opts: %#v", opts)

err := conn.DeleteNewRelicOTLP(opts)

errRes, ok := err.(*gofastly.HTTPError)
if !ok {
return err
}
// 404 response codes don't result in an error propagating because a 404 could
// indicate that a resource was deleted elsewhere.
if !errRes.IsNotFound() {
return err
}
return nil
}

// flattenNewRelicOTLP models data into format suitable for saving to Terraform state.
func flattenNewRelicOTLP(remoteState []*gofastly.NewRelicOTLP) []map[string]any {
var result []map[string]any
for _, resource := range remoteState {
data := map[string]any{
"name": resource.Name,
"token": resource.Token,
"format": resource.Format,
"format_version": resource.FormatVersion,
"placement": resource.Placement,
"region": resource.Region,
"response_condition": resource.ResponseCondition,
"url": resource.URL,
}

// Prune any empty values that come from the default string value in structs.
for k, v := range data {
if v == "" {
delete(data, k)
}
}

result = append(result, data)
}

return result
}

func (h *NewRelicOTLPServiceAttributeHandler) buildCreate(newrelicotlpMap any, serviceID string, serviceVersion int) *gofastly.CreateNewRelicOTLPInput {
resource := newrelicotlpMap.(map[string]any)

vla := h.getVCLLoggingAttributes(resource)
opts := &gofastly.CreateNewRelicOTLPInput{
Format: gofastly.String(vla.format),
FormatVersion: vla.formatVersion,
Name: gofastly.String(resource["name"].(string)),
Region: gofastly.String(resource["region"].(string)),
ServiceID: serviceID,
ServiceVersion: serviceVersion,
Token: gofastly.String(resource["token"].(string)),
URL: gofastly.String(resource["url"].(string)),
}

// WARNING: The following fields shouldn't have an empty string passed.
// As it will cause the Fastly API to return an error.
// This is because go-fastly v7+ will not 'omitempty' due to pointer type.
Integralist marked this conversation as resolved.
Show resolved Hide resolved
if vla.placement != "" {
opts.Placement = gofastly.String(vla.placement)
}
if vla.responseCondition != "" {
opts.ResponseCondition = gofastly.String(vla.responseCondition)
}

return opts
}
Loading