-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mTLS from state that returns 404 #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 Thanks for opening this PR!
I don't think the if
condition works as expected. Take a look at this reduced test case and let me know your thoughts.
Thanks.
Agree. If the type assertion fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR @hvtonev
This is now approved and I'll look to get it merged shortly.
/ok-to-test |
* ci: fix ok-to-test * ci: add missing configuration for ok-to-test behaviour
@hvtonev would it be possible to merge the latest |
@Integralist Done |
/ok-to-test |
* ci: fix ok-to-test * ci: add missing configuration for ok-to-test behaviour
/ok-to-test |
* ci: fix ok-to-test * ci: add missing configuration for ok-to-test behaviour
/ok-to-test |
ca6d334
to
72bb441
Compare
/ok-to-test sha=1fd5766 |
When TLS Mutual Authentication is removed outside of terraform the following error occurs.
Expected is to be removed from the state instead, similar to TLS Subscription