Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mTLS from state that returns 404 #794

Merged
merged 9 commits into from
Jan 3, 2024
Merged

Remove mTLS from state that returns 404 #794

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1fb57fb
Remove mTLS from state that returns 404
Dec 28, 2023
61ddeed
Remove mTLS from state that returns 404, fix ifs
Dec 29, 2023
e136f7d
ci: fix ok-to-test (#796)
Integralist Jan 2, 2024
e04a0eb
Merge remote-tracking branch 'upstream/main' into rm-mtls-on-404
Jan 2, 2024
e0f27f6
ci: fix ok-to-test (#796)
Integralist Jan 2, 2024
eee7bcf
Merge branch 'main' into rm-mtls-on-404
Integralist Jan 2, 2024
793c627
ci: fix ok-to-test (#796)
Integralist Jan 2, 2024
c473483
Merge branch 'main' into rm-mtls-on-404
Integralist Jan 2, 2024
1fd5766
Merge branch 'main' into rm-mtls-on-404
Integralist Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions fastly/resource_fastly_tls_mutual_authentication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@ package fastly

import (
"context"
"fmt"
"log"
"sort"

gofastly "github.com/fastly/go-fastly/v8/fastly"
"github.com/hashicorp/go-cty/cty"
"github.com/fastly/go-fastly/v8/fastly"
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
Expand Down Expand Up @@ -104,7 +107,19 @@ func resourceFastlyTLSMutualAuthenticationRead(_ context.Context, d *schema.Reso
log.Printf("[DEBUG] REFRESH: TLS Mutual Authentication input: %#v", input)

tma, err := conn.GetTLSMutualAuthentication(input)

if err != nil {
if err, ok := err.(*gofastly.HTTPError); ok && err.IsNotFound() {
id := d.Id()
d.SetId("")
return diag.Diagnostics{
diag.Diagnostic{
Severity: diag.Warning,
Summary: fmt.Sprintf("TLS Mutual Authentication (%s) not found - removing from state", id),
AttributePath: cty.Path{cty.GetAttrStep{Name: id}},
},
}
}
return diag.FromErr(err)
}

Expand Down