Add basic coverage to RailsStats::CodeStatistics#to_s #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's certainly a bunch of files, but guess they are all in the test directory. |
|
@bleonard Cool, thanks! Do you think this is ready to be merged? I just solved the conflict. 😄 |
|
@bleonard One more thing, could you enable Travis CI for this project? Or do you prefer checks with GitHub Actions? |
arielj
requested changes
Oct 14, 2020
| @@ -1 +1,12 @@ | |||
| require "rails_stats" | |||
There was a problem hiding this comment.
Removing this lines makes the rake command unable to find the stats task.
test/test_helper.rb
Outdated
| require "minitest/pride" | ||
| require "minitest/around/spec" | ||
|
|
||
| require "rails_stats/all" |
There was a problem hiding this comment.
Just nit picking here, but it's warning about a missing trailing new line
… tests by default Considering there were no tests, I decided to use minitest and set it up to run by default (`bundle exec rake`) I added a simple test to make sure that `to_s` is working as expected
|
@arielj Thanks for reviewing this PR! Just addressed your comments 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bleonard,
This PR adds minitest to the project and it adds a simple scenario for
RailsStats::CodeStatistics#to_sI added a Rails 6.0 application in test/dummy to make it easier to test
rails_stats. I didn't want to add a lot of tests before getting your feedback. Do you think this is a step in the right direction?This is what it should look like in your test environment:
Please let me know.
Thanks!