Feature/output json string #13
Closed
+1,114
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests by default Considering there were no tests, I decided to use minitest and set it up to run by default (`bundle exec rake`) I added a simple test to make sure that `to_s` is working as expected
This commit adds a new formatter (JSON) and it refactors CodeStatistics to coordinate between calculator and formatter. The goal is to be able to call the rake stats with a parameter that will output the result in JSON format.
|
@etagwerker I think this needs a rebase |
|
@etagwerker #18 is merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bleonard,
This is a PR which adds support for a JSON formatter (see #12). I'm not sure what is the preferred/best way to tell
rake statsto output JSON instead of a table in the console. Do you have any ideas about that?Please ignore the
test/dummyand all the duplicated code (I had to branch out of #10 to add coverage for this feature)This set of changes includes a small-ish refactor:
code_statistics.rbinto two (calculator calculates, formatter formats output)Please check it out when you get a minute. It might be easier to review this PR when you merge #10. 😄
Thanks!