-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency on bundler-stats and improve output #21
Conversation
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 73.03% 82.57% +9.53%
==========================================
Files 19 19
Lines 686 677 -9
==========================================
+ Hits 501 559 +58
+ Misses 185 118 -67
Continue to review full report at Codecov.
|
hi @torresga! could you please review this PR? thanks! |
@kindoflew Hey I took a look at the PR - I did notice some of the tests are failing though - is that supposed to be happening? Should we take a look at that more in detail? |
@torresga, thanks! it probably isn't, but while I was busy trying to follow the stack trace, it seems @etagwerker was already working on a solution and opened a PR elsewhere to fix it 😅 . |
Looking into it. It seems to be a very specific issue related to bundler stats and github CI. |
Since bundler-stats/#19 is merged, can the new version be added yet or do we have to wait for a new release? |
Now sorting is alphabetically for gems with the same number of Total Deps
@kindoflew I just updated my changes to work with the latest version of bundler-stats... I see that there are still a couple of failed jobs. I'll look into this now. |
@kindoflew @torresga I finally got a passing test suite + codecov job! I had to tweak the tests to increase code coverage (because Codecov was complaining about diminishing test coverage percentage) and I had to add a different expectation for the Ruby 2.4 job (apparently number of dependencies is different for that version of Ruby) Please take another look and let me know what you think. Thanks! |
Looks good to me! |
Hey,
This PR fixes #11 by adding a dependency to
bundler-stats
and including a call to its CLI.Please check it out.
Thanks!