Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on bundler-stats and improve output #21

Merged
merged 14 commits into from
Dec 2, 2021
Merged

Conversation

etagwerker
Copy link
Member

Hey,

This PR fixes #11 by adding a dependency to bundler-stats and including a call to its CLI.

Please check it out.

Thanks!

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #21 (601594d) into main (cbeff8c) will increase coverage by 9.53%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   73.03%   82.57%   +9.53%     
==========================================
  Files          19       19              
  Lines         686      677       -9     
==========================================
+ Hits          501      559      +58     
+ Misses        185      118      -67     
Impacted Files Coverage Δ
test/lib/rails_stats/json_formatter_test.rb 100.00% <ø> (ø)
lib/rails_stats/app_statistics.rb 97.29% <87.50%> (+1.46%) ⬆️
lib/rails_stats/console_formatter.rb 100.00% <100.00%> (ø)
lib/rails_stats/inflector.rb 73.23% <0.00%> (+0.50%) ⬆️
lib/rails_stats/stats_calculator.rb 97.33% <0.00%> (+2.66%) ⬆️
lib/rails_stats/util.rb 96.66% <0.00%> (+11.66%) ⬆️
lib/rails_stats/spec_statistics.rb 97.43% <0.00%> (+71.79%) ⬆️
lib/rails_stats/test_statistics.rb 97.43% <0.00%> (+71.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbeff8c...601594d. Read the comment docs.

@kindoflew
Copy link
Contributor

hi @torresga! could you please review this PR? thanks!

@kindoflew kindoflew requested a review from torresga November 22, 2021 16:32
@torresga
Copy link

@kindoflew Hey I took a look at the PR - I did notice some of the tests are failing though - is that supposed to be happening? Should we take a look at that more in detail?

@kindoflew
Copy link
Contributor

@torresga, thanks! it probably isn't, but while I was busy trying to follow the stack trace, it seems @etagwerker was already working on a solution and opened a PR elsewhere to fix it 😅 .

@etagwerker
Copy link
Member Author

Looking into it. It seems to be a very specific issue related to bundler stats and github CI.

@kindoflew
Copy link
Contributor

Since bundler-stats/#19 is merged, can the new version be added yet or do we have to wait for a new release?

Now sorting is alphabetically for gems with the same number of Total Deps
@etagwerker
Copy link
Member Author

@kindoflew I just updated my changes to work with the latest version of bundler-stats...

I see that there are still a couple of failed jobs. I'll look into this now.

@etagwerker
Copy link
Member Author

@kindoflew @torresga I finally got a passing test suite + codecov job!

I had to tweak the tests to increase code coverage (because Codecov was complaining about diminishing test coverage percentage) and I had to add a different expectation for the Ruby 2.4 job (apparently number of dependencies is different for that version of Ruby)

Please take another look and let me know what you think. Thanks!

@kindoflew
Copy link
Contributor

Looks good to me!

@lubc lubc merged commit 23018bc into main Dec 2, 2021
@lubc lubc deleted the feature/bundler-stats branch December 2, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: Output number of dependencies in Gemfile.lock
4 participants