-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ArgumentError within GitHub CI environment: invalid value for Integer(): "" #18
Comments
etagwerker
added a commit
to fastruby/bundler-stats
that referenced
this issue
Nov 23, 2021
etagwerker
added a commit
to fastruby/bundler-stats
that referenced
this issue
Nov 23, 2021
etagwerker
added a commit
to fastruby/bundler-stats
that referenced
this issue
Nov 24, 2021
etagwerker
added a commit
to fastruby/rails_stats
that referenced
this issue
Nov 25, 2021
jmmastey
pushed a commit
that referenced
this issue
Nov 27, 2021
* Add support for when tput returns an error message * Add scenario when tput returns an error and Integer can't parse string This fixes #18 * Adjust rescue argument to rescue StandardError when calling `tput`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @jmmastey,
Thanks for creating this gem! It has been very useful in estimating how big a Ruby/Rails application really is. I wrote a little bit about it over here: How we estimate the size of a Rails application
I wanted to incorporate it to
rails_stats
as a way to get both bundler and LOC stats, so I went ahead and submitted: fastruby/rails_stats#21Unfortunately my test suite fails with this error:
I see that in your test suite you stub the method that calls
tput
:bundler-stats/spec/lib/bundler/stats/printer_spec.rb
Lines 7 to 9 in b55fd31
I assume that is a good way to get around that issue in CI.
Would you be interested in a simple patch to this method?
Please let me know.
Thanks,
Ernesto
The text was updated successfully, but these errors were encountered: