Pass --tests flag to gometalinter so that we lint test files #1563
Conversation
Previously we'd lint test files. In the recent PR alecthomas/gometalinter#377, gometalinter stopped asking errcheck to lint tests. This change makes us again lint test files which I think is sensible.
|
I thought about adding a new option for this, but I have a hard time seeing someone wanting to turn it off. Also, this apparently changed recently in the PR I mentioned. I was used to having tests linted and I thought something was broken. But I'm certainly open to adding an option for this if you think that's better! |
autoload/go/lint.vim
Outdated
| " it means if we don't pass --tests, the linter won't run against test | ||
| " files. One example of a linter that will not run against tests if we do | ||
| " not specify this flag is errcheck. | ||
| let cmd += ["--tests"] |
There was a problem hiding this comment.
I think it might be better to put this in the if a:autosave || empty(g:go_metalinter_command) block above.
That way people who have g:go_metalinter_command defined – which is documented as "for users who want to have a complete control over how gometalinter should be executed" – won't have this extra flag, which also addresses your comment and gives people a way to disable it if they really want to.
This avoids adding the flag if the option to set the gometalinter command is set.
|
Great point! I moved it as suggested. Thanks for looking at this. |
|
LGTM Thank you for contributing @horgh! |
Previously we'd lint test files. In the recent PR
alecthomas/gometalinter#377, gometalinter stopped asking errcheck to
lint tests. This change makes us again lint test files which I think is
sensible.